France
Joined: Nov 7, 2005
Post Count: 9426
Status:
Offline
Re: Progress and time of photo rendering
If you want to update the plug-in on SourceForge.net, just edit your initial comment there and delete the existing attachement and add a new one. Don't you have access to these tools?
By the way, thanks for trying to improve the existing renderer, but could you give some details about what you changed? Please add some comments in your source files with GNU GPL headers and notices about the changes you made compared to original source files? The section 2 of this license states how you should proceed when you make some changes to some existing source code.
I'm not convinced about the progress bar in Sweet Home 3D photo creation tool, mainly because it will hardly give precise results. As soon as the Sunflow is working on rendering glasses, you know that it takes much longer and you can't guess it. I know that the the progress bar in Sweet Home 3D video creation tool is not precise too, but it was added there first for user's feedback purpose, whereas in the photo creation tool, the feedback is already shown with the buckets.
----------------------------------------
Emmanuel Puybaret, Sweet Home 3D creator
Netherlands
Joined: Sep 26, 2009
Post Count: 4002
Status:
Offline
Re: Progress and time of photo rendering
When making test renders, people tend to compare the time one test takes with the time of another test. Especially in Q4, rendering can take a long time. Longer than one is willing to wait and watch the screen to time the duration. A built-in timer would give the time, while people can make coffee, take a shower or go shopping.
Joined: May 28, 2015
Post Count: 607
Status:
Offline
Re: Progress and time of photo rendering
Emmanuel,
On SourceForge, I can only edit comments in discussion.
Information about the GNU GPL license and the changes made to the SH3D source code have been added to the plug-in Java sources. Compared to the original photo panel, the plug-in allows : - a display of buckets in row with the same visual size regardless of the image width - ceiling lights a little less dazzling and sometimes centered differently - rendering aerial view identical to that in virtual visit - a reduced number of samples in global illumination "path"
For sure the buckets gives an idea of the progress but the progress bar can also be useful for an ipr rendering. The elapsed time is a further indication even if the estimated remaining time is less accurate.
----------------------------------------
EnkoNyito
France
Joined: Nov 7, 2005
Post Count: 9426
Status:
Offline
Re: Progress and time of photo rendering
I renamed the ticket of this plug-in for you. Thanks for the comments in SunflowRenderer.java and AdvancedPhotoPanel.java classes showing the changes you made. Just one missing thing for next time: you should mention where these classes come from, and add the original @author tags of these classes. The idea behind these requirements is that anybody who wants to keep track of the changes you made should be able to find your sources.
----------------------------------------
Emmanuel Puybaret, Sweet Home 3D creator
Joined: May 28, 2015
Post Count: 607
Status:
Offline
Re: Progress and time of photo rendering (Create photo with renderer plug-in)
Santbose,
As said Mazoola, Sunflow uses different types of light for a sky without texture (SunSkyLight) and a sky with texture (ImageBasedLight). Although they have a parameter that seems common, rendering for a sky with texture depends on the image used (example: blue sky or cloudy sky).
